Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Pageview refactor #1132

Merged
merged 4 commits into from
Apr 11, 2024
Merged

chore: Pageview refactor #1132

merged 4 commits into from
Apr 11, 2024

Conversation

benjackwhite
Copy link
Collaborator

Changes

Part of heatmaps work - wanted to separate the scroll calculations from pageviews so they could be used elsewhere more easily.

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite changed the base branch from main to feat/heatmaps-part2 April 10, 2024 22:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

Size Change: -2.65 kB (0%)

Total Size: 948 kB

Filename Size Change
dist/array.full.js 226 kB -663 B (0%)
dist/array.js 127 kB -663 B (-1%)
dist/es.js 127 kB -663 B (-1%)
dist/module.js 127 kB -663 B (-1%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.2 kB
dist/recorder-v2.js 105 kB
dist/recorder.js 105 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@benjackwhite benjackwhite marked this pull request as ready for review April 11, 2024 09:10
@benjackwhite benjackwhite merged commit 97ad2b5 into feat/heatmaps-part2 Apr 11, 2024
11 checks passed
@benjackwhite benjackwhite deleted the feat/heatmaps-pageview-refactor branch April 11, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benjackwhite